-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-6529] Use persistent sessionContext in AvaticaCommonsHttpClie… #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with this part of the codebase, but these changes look reasonable.
The CI failed for macos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the commit message and PR title to: [CALCITE-6529] xxxxx
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java
Show resolved
Hide resolved
@@ -109,34 +110,33 @@ protected void initializeClient(PoolingHttpClientConnectionManager pool, | |||
HttpClientBuilder httpClientBuilder = HttpClients.custom().setConnectionManager(pool) | |||
.setDefaultRequestConfig(requestConfig); | |||
this.client = httpClientBuilder.build(); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried setting these directly on the client object ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet but i will try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried setting these directly on the client object, but I think it would require quite a lot of refactoring. For example, practically the whole AvaticaHttpClientFactoryImpl class should be rewritten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Maybe in a followup ticket.
core/src/main/java/org/apache/calcite/avatica/remote/AvaticaCommonsHttpClientImpl.java
Outdated
Show resolved
Hide resolved
@@ -109,34 +110,33 @@ protected void initializeClient(PoolingHttpClientConnectionManager pool, | |||
HttpClientBuilder httpClientBuilder = HttpClients.custom().setConnectionManager(pool) | |||
.setDefaultRequestConfig(requestConfig); | |||
this.client = httpClientBuilder.build(); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Maybe in a followup ticket.
Please fix the commit message to use square brackets, @szucsvillo . |
bffba9d
to
dfe9f99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
…ntImpl