[CALCITE-6141] Add jdk8.checkstyle property, use jdk8.checkstyle in case of java 8 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snuyanzin Can you open a jira issue for this and update the commit message? |
…in case of java 8
snuyanzin
force-pushed
the
jdk8checkstyle
branch
from
a950876
to
ad4bfbc
Compare
snuyanzin
changed the title
|
@F21 yes, sure, jira issue is created CALCITE-6141, also commit message changed |
F21
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to use
jdk8.checkstyle.versiongradle property which will be used in case of java 8for other java version
checstyle.versionwill be usedThis allows to compile Avatica with java 8 without explicitly set checkstyle version
also mentioned at https://lists.apache.org/thread/r27kdvvhr0222nqlog7xzn5y3yjvz6jp