Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-5748] Guava 32.1.1-jre #220

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[CALCITE-5748] Guava 32.1.1-jre #220

merged 1 commit into from
Aug 3, 2023

Conversation

snuyanzin
Copy link
Contributor

No description provided.

@richardantal
Copy link

I wonder if there is a reason why we don't go to the latest/greatest 32.1.1?

@snuyanzin
Copy link
Contributor Author

the PR was created when only 32.0.0 was present, that's the reason
i will update it

@snuyanzin snuyanzin changed the title [CALCITE-5748] Guava 32.0.0-jre [CALCITE-5748] Guava 32.1.1-jre Jul 19, 2023
@richardantal
Copy link

Looks good to me, Thank you Sergey for the change.
I don't have permissions to review, maybe @stoty does.

stoty
stoty approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@snuyanzin
Copy link
Contributor Author

Thanks for having a look and sorry for the delay

@snuyanzin
Copy link
Contributor Author

rebased and squashed commits

@snuyanzin snuyanzin merged commit 2736c27 into apache:main Aug 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoty stoty stoty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snuyanzin @richardantal @stoty