[KafkaIO] Fix per-split metric updates for KafkaUnboundedReader and ReadFromKafkaDoFn #32921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #31137 and #31281. The changes in the former PR overwrite the per-split metric
backlog_bytes.${SPLIT}
with the per-partition metric rather than the accumulated value for the split. The latter PR introduced a map to store metrics for all past and current splits (1 partition) of theReadFromKafkaDoFn
instance and may repeatedly overwrite non-current splits with stale values. The map used to store these values is not thread-safe and may trigger aConcurrentModificationException
sinceGetSize
and other SDF methods may concurrently attempt to read and write the map.Finally, the per-split caches kept by the instance are keyed on
TopicPartition
, which is not unique among all splits since the split may override the bootstrap server. This has been fixed for this cache, all other caches will be patched in a separate PR.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.