GH-45167: [C++] Implement Compute Equals for List Types #45272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WillAyd
commented
Jan 15, 2025
github-actions
bot
added
awaiting committer review
WillAyd
force-pushed
the
implement-list-compare
branch
from
573867e to
649e3b0
Compare
WillAyd
commented
Jan 17, 2025
WillAyd
force-pushed
the
implement-list-compare
branch
from
649e3b0 to
68bb513
Compare
WillAyd
commented
Jan 21, 2025
| explicit ArrayIterator(const ArraySpan& arr) : arr(arr), position(0) {} | ||
|
|
||
| T operator()() { | ||
| const auto array_ptr = arr.ToArray(); |
There was a problem hiding this comment.
The alternative to calling ToArray with the cast would be to implement something like value_slice on the ArraySpan directly, although I'm not sure if the ArraySpan is supposed to return anything but pointers to primitives (as is currently implemeted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While equality exists for ListScalars, it is not available through the compute module. This makes that now possible.
What changes are included in this PR?
I have added equals and not_equals support to the compute module for list types
Are these changes tested?
Yes - see added changes
Are there any user-facing changes?
Yes - the new feature to allow list comparison through the compute module