GH-45357: [C++] Disable Flight test #45232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting committer review
|
The failing test is #45235 |
|
Not crucial, but since 19.0.1 is now happening, it'd be nice to backport this patch, as we cannot do without in conda-forge (though it's not a big hassle to keep carrying it either, but I always try to reduce the patches we carry). CC @amoeba |
raulcd
reviewed
Jan 24, 2025
github-actions
bot
added
awaiting review
Co-authored-by: Raúl Cumplido <[email protected]>
github-actions
bot
added
awaiting review
raulcd
changed the title
|
|
raulcd
approved these changes
Jan 27, 2025
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 14e45a2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 30, 2025
### Rationale for this change See apache#45120 ### What changes are included in this PR? Disable pointless test ### Are these changes tested? N/A ### Are there any user-facing changes? No * GitHub Issue: apache#45357 Lead-authored-by: David Li <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
amoeba
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Rationale for this change See #45120 ### What changes are included in this PR? Disable pointless test ### Are these changes tested? N/A ### Are there any user-facing changes? No * GitHub Issue: #45357 Lead-authored-by: David Li <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
amoeba
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Rationale for this change See #45120 ### What changes are included in this PR? Disable pointless test ### Are these changes tested? N/A ### Are there any user-facing changes? No * GitHub Issue: #45357 Lead-authored-by: David Li <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #45120
What changes are included in this PR?
Disable pointless test
Are these changes tested?
N/A
Are there any user-facing changes?
No