MINOR: [Docs] Update docs to point to separate Java codebase #45134
Conversation
github-actions
bot
added
Component: Documentation
awaiting review
|
These changes are pretty trivial + are mainly for docs that aren't specifically related to java. Though one remaining issue is that the following pages/sub-pages still live in this repo which I assume isn't desired 🤔 . |
kou
changed the title
github-actions
bot
added
awaiting changes
|
@github-actions crossbow submit preview-docs |
|
Revision: 1a0d899 Submitted crossbow builds: ursacomputing/crossbow @ actions-c3413aeb10
|
Co-authored-by: Sutou Kouhei <[email protected]>
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
|
Could you also update |
github-actions
bot
added
awaiting change review
|
@github-actions crossbow submit preview-docs |
|
| @@ -144,7 +144,7 @@ Maven | |||
|
|
|||
| .. code-block:: | |||
|
|
|||
| $ cd arrow/java | |||
| $ cd arrow-java | |||
| $ mvn generate-resources -Pgenerate-libs-jni-windows -N | |||
There was a problem hiding this comment.
Building JNI libs with maven is broken until the pom.xml file is updated in arrow-java to avoid passing -S java to cmake among other problems.
There was a problem hiding this comment.
Should we wait for apache/arrow-java#449 ?
There was a problem hiding this comment.
Yup, I'll wait on apache/arrow-java#449.
Will this order work?
- GH-13: Set up JNI build (dataset, etc.) arrow-java#449 lands
- I'll try to verify each build path and update the docs on this PR -> merge it into apache/arrow
[Docs] Migrate java development and usage docs from apache/arrow arrow-java#472[Doc] Generate Java documentation arrow-java#455 (I can try to cherry-pick the commits in the docs in a similar way that was done for the source code)- Remove java docs from apache/arrow
| @@ -293,7 +300,7 @@ Archery | |||
|
|
|||
| .. code-block:: text | |||
|
|
|||
| $ cd arrow | |||
| $ cd arrow-java | |||
There was a problem hiding this comment.
Bit unfamiliar with archery, but I couldn't find any directives/targets for java-jni-manylinux-2014 in any of the dockerfiles between both repos.
There was a problem hiding this comment.
We can use docker compose instead of Archery.
apache/arrow-java uses docker compose directly instead of via Archery.
There was a problem hiding this comment.
Ah I see, after apache/arrow-java#449 I can replace the archery sections with docker compose
Updated + tweaked the build instructions for the JNI libraries. I commented on this review a few more problems in the "building Java" docs. Some need source fixes to be done in arrow-java - could these updates be made once the java documentation has moved to apache/arrow-java maybe? |
|
@github-actions crossbow submit preview-docs |
github-actions
bot
added
awaiting changes
|
Revision: 197369e Submitted crossbow builds: ursacomputing/crossbow @ actions-88de21002f
|
Rationale for this change
Post #44945 the Java implementation lives in it's own repo. Update docs
to point there.
What changes are included in this PR?
Updates to a few locations that reference old Java impl location.
Are these changes tested?
Rendered the Sphinx ones locally to check.
Are there any user-facing changes?
No