Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [Release] Verify release-17.0.0-rc0 #43188

Closed
wants to merge 3 commits into from
Closed

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 8, 2024

PR to verify Release Candidate

@raulcd
Copy link
Member Author

raulcd commented Jul 8, 2024

@github-actions crossbow submit --group verify-rc-source --param release=17.0.0 --param rc=0

@raulcd
Copy link
Member Author

raulcd commented Jul 8, 2024

Revision: 741356c

Submitted crossbow builds: ursacomputing/crossbow @ release-17.0.0-rc0-0

Task Status
almalinux-8-amd64 GitHub Actions
almalinux-8-arm64 GitHub Actions
almalinux-9-amd64 GitHub Actions
almalinux-9-arm64 GitHub Actions
amazon-linux-2023-amd64 GitHub Actions
amazon-linux-2023-arm64 GitHub Actions
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions
conan-maximum GitHub Actions
conan-minimum GitHub Actions
debian-bookworm-amd64 GitHub Actions
debian-bookworm-arm64 GitHub Actions
debian-trixie-amd64 GitHub Actions
debian-trixie-arm64 GitHub Actions
java-jars GitHub Actions
matlab GitHub Actions
nuget GitHub Actions
python-sdist GitHub Actions
r-binary-packages GitHub Actions
test-debian-12-docs GitHub Actions
ubuntu-focal-amd64 GitHub Actions
ubuntu-focal-arm64 GitHub Actions
ubuntu-jammy-amd64 GitHub Actions
ubuntu-jammy-arm64 GitHub Actions
ubuntu-noble-amd64 GitHub Actions
ubuntu-noble-arm64 GitHub Actions
wheel-macos-big-sur-cp310-arm64 GitHub Actions
wheel-macos-big-sur-cp311-arm64 GitHub Actions
wheel-macos-big-sur-cp312-arm64 GitHub Actions
wheel-macos-big-sur-cp38-arm64 GitHub Actions
wheel-macos-big-sur-cp39-arm64 GitHub Actions
wheel-macos-catalina-cp310-amd64 GitHub Actions
wheel-macos-catalina-cp311-amd64 GitHub Actions
wheel-macos-catalina-cp312-amd64 GitHub Actions
wheel-macos-catalina-cp38-amd64 GitHub Actions
wheel-macos-catalina-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp38-amd64 GitHub Actions
wheel-manylinux-2-28-cp38-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp38-amd64 GitHub Actions
wheel-manylinux-2014-cp38-arm64 GitHub Actions
wheel-manylinux-2014-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-arm64 GitHub Actions
wheel-windows-cp310-amd64 GitHub Actions
wheel-windows-cp311-amd64 GitHub Actions
wheel-windows-cp312-amd64 GitHub Actions
wheel-windows-cp38-amd64 GitHub Actions
wheel-windows-cp39-amd64 GitHub Actions

Copy link

github-actions bot commented Jul 8, 2024

Revision: 741356c

Submitted crossbow builds: ursacomputing/crossbow @ actions-43bbd68d28

Task Status
verify-rc-source-cpp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-cpp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-csharp-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-csharp-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-csharp-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-go-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-go-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-go-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-go-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-go-macos-amd64 GitHub Actions
verify-rc-source-go-macos-arm64 GitHub Actions
verify-rc-source-integration-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-java-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-java-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions
verify-rc-source-js-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-js-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-js-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-python-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-linux-almalinux-8-amd64 GitHub Actions
verify-rc-source-ruby-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-20.04-amd64 GitHub Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions
verify-rc-source-windows GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jul 8, 2024

I'll investigate tomorrow what is wrong on the verification tasks but it seems that the changes for the tags / gh releases (here: 6ec2f22) have done something wrong to the tar.gz on the 02-source.sh and both binaries and verification tasks are failing due to an empty tar file.
FYI @sgilmore10 @kou

@sgilmore10
Copy link
Member

I'll investigate tomorrow what is wrong on the verification tasks but it seems that the changes for the tags / gh releases (here: 6ec2f22) have done something wrong to the tar.gz on the 02-source.sh and both binaries and verification tasks are failing due to an empty tar file.

Sorry about that @raulcd! Kevin and I will take a look at this asap.

@raulcd
Copy link
Member Author

raulcd commented Jul 8, 2024

Sorry about that @raulcd! Kevin and I will take a look at this asap.

No worries, I've just added you FYI, happy if you can take a look otherwise I'll start to investigate tomorrow as is pretty late here at the moment :) But it seems is just the tar.gz name once untared. It changed from 16.1.0-rc1 release (https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-16.1.0-rc1/):

$ tar zxvf apache-arrow-16.1.0.tar.gz 
...
$ ls
apache-arrow-16.1.0  apache-arrow-16.1.0.tar.gz

to 17.0.0-rc0 (https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-17.0.0-rc0/)

$ tar zxvf apache-arrow-17.0.0.tar.gz
...
$ ls
apache-arrow-17.0.0-rc0  apache-arrow-17.0.0.tar.gz

See -rc0 is present on the tar.gz directory name which is unexpected

@sgilmore10
Copy link
Member

Sorry about that @raulcd! Kevin and I will take a look at this asap.

No worries, I've just added you FYI, happy if you can take a look otherwise I'll start to investigate tomorrow as is pretty late here at the moment :) But it seems is just the tar.gz name once untared. It changed from 16.1.0-rc1 release (https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-16.1.0-rc1/):

$ tar zxvf apache-arrow-16.1.0.tar.gz 
...
$ ls
apache-arrow-16.1.0  apache-arrow-16.1.0.tar.gz

to 17.0.0-rc0 (https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-17.0.0-rc0/)

$ tar zxvf apache-arrow-17.0.0.tar.gz
...
$ ls
apache-arrow-17.0.0-rc0  apache-arrow-17.0.0.tar.gz

See -rc0 is present on the tar.gz directory name which is unexpected

That's a good catch. @kevingurney and I were able to confirm this on our end as well. We'll take a look at 02-source.sh and see if there's anything obviously wrong there.

@sgilmore10
Copy link
Member

sgilmore10 commented Jul 8, 2024

Actually, it looks like there's a bug in dev/release/utils-create-release-tarball.sh. The name of the directory from which the tarball is created is based on the git tag, and therefore, contains the rcN suffix. Adding a separate variable called tag_no_rc and using that as the folder name should resolve the issue.

@raulcd, how would like to go about fixing this bug? I can create a PR. Or would it be preferable to fix this bug on this branch?

@kou
Copy link
Member

kou commented Jul 9, 2024

Could you open a PR for main?
We can cherry-pick it to a release branch after we merge it into main.

@sgilmore10
Copy link
Member

Just submitted a PR (#43200) that should fix the issue. Sorry for the inconvenience this has caused you @raulcd!

raulcd pushed a commit that referenced this pull request Jul 9, 2024
… should not include the release candidate number in the name of the tarball's top-level directory. (#43200)

### Rationale for this change

`dev/release/util-create-release-tarball.sh` should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See #43188 (comment). 

### What changes are included in this PR?

1. Modified `dev/release/util-create-release-tarball.sh` to not include the release candidate number in the name of the source directory from which the release tarball is created.

### Are these changes tested?

Manually verified this change fixes the bug:

```bash
$ dev/release/utils-create-release-tarball.sh 17.0.0 1
$ tar zxvf apache-arrow-17.0.0.tar.gz
...
$ ls 
apache-arrow-17.0.0/       apache-arrow-17.0.0.tar.gz
```

### Are there any user-facing changes?

No

* GitHub Issue: #43199

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
raulcd pushed a commit that referenced this pull request Jul 9, 2024
… should not include the release candidate number in the name of the tarball's top-level directory. (#43200)

### Rationale for this change

`dev/release/util-create-release-tarball.sh` should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See #43188 (comment). 

### What changes are included in this PR?

1. Modified `dev/release/util-create-release-tarball.sh` to not include the release candidate number in the name of the source directory from which the release tarball is created.

### Are these changes tested?

Manually verified this change fixes the bug:

```bash
$ dev/release/utils-create-release-tarball.sh 17.0.0 1
$ tar zxvf apache-arrow-17.0.0.tar.gz
...
$ ls 
apache-arrow-17.0.0/       apache-arrow-17.0.0.tar.gz
```

### Are there any user-facing changes?

No

* GitHub Issue: #43199

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Jul 9, 2024
…all.sh should not include the release candidate number in the name of the tarball's top-level directory. (apache#43200)

### Rationale for this change

`dev/release/util-create-release-tarball.sh` should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See apache#43188 (comment). 

### What changes are included in this PR?

1. Modified `dev/release/util-create-release-tarball.sh` to not include the release candidate number in the name of the source directory from which the release tarball is created.

### Are these changes tested?

Manually verified this change fixes the bug:

```bash
$ dev/release/utils-create-release-tarball.sh 17.0.0 1
$ tar zxvf apache-arrow-17.0.0.tar.gz
...
$ ls 
apache-arrow-17.0.0/       apache-arrow-17.0.0.tar.gz
```

### Are there any user-facing changes?

No

* GitHub Issue: apache#43199

Authored-by: Sarah Gilmore <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd
Copy link
Member Author

raulcd commented Jul 9, 2024

Closing in favor of RC1

@raulcd raulcd closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants