-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [Release] Verify release-17.0.0-rc0 #43188
Conversation
@github-actions crossbow submit --group verify-rc-source --param release=17.0.0 --param rc=0 |
Revision: 741356c Submitted crossbow builds: ursacomputing/crossbow @ release-17.0.0-rc0-0 |
Revision: 741356c Submitted crossbow builds: ursacomputing/crossbow @ actions-43bbd68d28 |
I'll investigate tomorrow what is wrong on the verification tasks but it seems that the changes for the tags / gh releases (here: 6ec2f22) have done something wrong to the |
Sorry about that @raulcd! Kevin and I will take a look at this asap. |
No worries, I've just added you FYI, happy if you can take a look otherwise I'll start to investigate tomorrow as is pretty late here at the moment :) But it seems is just the
to 17.0.0-rc0 (https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-17.0.0-rc0/)
See |
That's a good catch. @kevingurney and I were able to confirm this on our end as well. We'll take a look at |
Actually, it looks like there's a bug in @raulcd, how would like to go about fixing this bug? I can create a PR. Or would it be preferable to fix this bug on this branch? |
Could you open a PR for main? |
… should not include the release candidate number in the name of the tarball's top-level directory. (#43200) ### Rationale for this change `dev/release/util-create-release-tarball.sh` should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See #43188 (comment). ### What changes are included in this PR? 1. Modified `dev/release/util-create-release-tarball.sh` to not include the release candidate number in the name of the source directory from which the release tarball is created. ### Are these changes tested? Manually verified this change fixes the bug: ```bash $ dev/release/utils-create-release-tarball.sh 17.0.0 1 $ tar zxvf apache-arrow-17.0.0.tar.gz ... $ ls apache-arrow-17.0.0/ apache-arrow-17.0.0.tar.gz ``` ### Are there any user-facing changes? No * GitHub Issue: #43199 Authored-by: Sarah Gilmore <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
… should not include the release candidate number in the name of the tarball's top-level directory. (#43200) ### Rationale for this change `dev/release/util-create-release-tarball.sh` should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See #43188 (comment). ### What changes are included in this PR? 1. Modified `dev/release/util-create-release-tarball.sh` to not include the release candidate number in the name of the source directory from which the release tarball is created. ### Are these changes tested? Manually verified this change fixes the bug: ```bash $ dev/release/utils-create-release-tarball.sh 17.0.0 1 $ tar zxvf apache-arrow-17.0.0.tar.gz ... $ ls apache-arrow-17.0.0/ apache-arrow-17.0.0.tar.gz ``` ### Are there any user-facing changes? No * GitHub Issue: #43199 Authored-by: Sarah Gilmore <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…all.sh should not include the release candidate number in the name of the tarball's top-level directory. (apache#43200) ### Rationale for this change `dev/release/util-create-release-tarball.sh` should not include the release candidate number in the name of the tarball's top-level directory. If the release candidate number is included, the binaries and the release verification tasks fail because the tarball entries have an unexpected folder hierarchy. See apache#43188 (comment). ### What changes are included in this PR? 1. Modified `dev/release/util-create-release-tarball.sh` to not include the release candidate number in the name of the source directory from which the release tarball is created. ### Are these changes tested? Manually verified this change fixes the bug: ```bash $ dev/release/utils-create-release-tarball.sh 17.0.0 1 $ tar zxvf apache-arrow-17.0.0.tar.gz ... $ ls apache-arrow-17.0.0/ apache-arrow-17.0.0.tar.gz ``` ### Are there any user-facing changes? No * GitHub Issue: apache#43199 Authored-by: Sarah Gilmore <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Closing in favor of RC1 |
PR to verify Release Candidate