Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packed_simd and run miri tests on simd code #4654

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Update packed_simd and run miri tests on simd code #4654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf2975
Update packed_simd and run miri tests on simd code
jhorstmann Aug 6, 2023
5113c65
Unpin nightly version
jhorstmann Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/arrow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,7 @@ jobs:
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
# Pinned nightly (#4651)
rust-version: nightly-2023-08-03
rust-version: nightly
- name: Test arrow-array with SIMD
run: cargo test -p arrow-array --features simd
- name: Test arrow-ord with SIMD
Expand All @@ -169,8 +168,7 @@ jobs:
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
# Pinned nightly (#4651)
rust-version: nightly-2023-08-03
rust-version: nightly
target: wasm32-unknown-unknown,wasm32-wasi
- name: Build wasm32-unknown-unknown
run: cargo build -p arrow --no-default-features --features=json,csv,ipc,simd,ffi --target wasm32-unknown-unknown
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ jobs:
strategy:
matrix:
arch: [ amd64 ]
# Pinned nightly (#4651)
rust: [ nightly-2023-08-03 ]
rust: [ nightly ]
container:
image: ${{ matrix.arch }}/rust
env:
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/miri.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@
# Must be run with nightly rust for example
# rustup default nightly


# stacked borrows checking uses too much memory to run successfully in github actions
# re-enable if the CI is migrated to something more powerful (https://github.com/apache/arrow-rs/issues/1833)
# see also https://github.com/rust-lang/miri/issues/1367
export MIRIFLAGS="-Zmiri-disable-isolation -Zmiri-disable-stacked-borrows"
export MIRIFLAGS="-Zmiri-disable-isolation"
cargo miri setup
cargo clean

Expand All @@ -18,3 +14,5 @@ cargo miri test -p arrow-buffer
cargo miri test -p arrow-data --features ffi
cargo miri test -p arrow-schema --features ffi
cargo miri test -p arrow-array
cargo miri test -p arrow-arith --features simd
cargo miri test -p arrow-ord --features simd
2 changes: 1 addition & 1 deletion arrow-array/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ chrono-tz = { version = "0.8", optional = true }
num = { version = "0.4.1", default-features = false, features = ["std"] }
half = { version = "2.1", default-features = false, features = ["num-traits"] }
hashbrown = { version = "0.14", default-features = false }
packed_simd = { version = "0.3", default-features = false, optional = true, package = "packed_simd_2" }
packed_simd = { version = "0.3.9", default-features = false, optional = true }

[features]
simd = ["packed_simd"]
Expand Down
Loading