Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation logic to wait until the consul port 8500 is open before starting mft (issue #128) #131

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

ShivangMishra
Copy link
Contributor

With this change, issue #128 is resolved.
image

@ShivangMishra
Copy link
Contributor Author

@smarru @DImuthuUpe could you please review and merge this PR?

Copy link
Contributor

@DImuthuUpe DImuthuUpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising. Can you make the wait loop bounded to 20 seconds?

@DImuthuUpe
Copy link
Contributor

Looks great. Thanks @ShivangMishra

@DImuthuUpe DImuthuUpe merged commit 3ccbfa2 into apache:master Apr 3, 2024
@ShivangMishra ShivangMishra deleted the issue-128 branch April 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants