This repository has been archived by the owner on Jul 11, 2019. It is now read-only.
Update to support newer log4js versions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For log4js v2 and v3, there is new parameter 'layouts' expected by console configure() function. For older release (v0 and v1) this parameter does not exist, but the change is backward-compatible (extra parameter ignored)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use new version of log4js in my project (e.g. because of some features like Typescript typings), but this appender has hardcoded reference to and older version and it fails at runtime with newer version. This PR is intended to introduce the necessary change in order to make it compatible with more recent versions of log4js.
For log4js v2 and v3, there is new parameter 'layouts' expected by console configure() function, which was added to configure() here.
For older release (v0 and v1) this parameter does not exist, but the change is backward-compatible (because extra parameter is ignored by JS).
I have changed version range to include the log4js v1, v2 and v3 (newest). I have executed tests with the appender once for each distinct major release.