-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slot metric to clean stat #3302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title and description talk about shrink and ancient shrink, but the datapoint is being added in clean, not shrink. Is that intentional?
Edit: Oh, I see the title and description has changed. All good now!
For my own curiosity, why is it useful to know what slot clean is working on? |
Co-authored-by: Brooks <[email protected]>
to know how often clean is running, to know whether a specific slot would have been included in that slot or not. It is sometimes useful to have that context. roots and frozen banks are way ahead of where we clean. Clean lags and runs in the background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem
It is useful to know what slot clean is working on.
Summary of Changes
Add slot metric to clean stat.
Fixes #