Add slot metric to clean stat #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
previously approved these changes
Oct 24, 2024
brooksprumo
reviewed
Oct 24, 2024
|
For my own curiosity, why is it useful to know what slot clean is working on? |
Co-authored-by: Brooks <[email protected]>
to know how often clean is running, to know whether a specific slot would have been included in that slot or not. It is sometimes useful to have that context. roots and frozen banks are way ahead of where we clean. Clean lags and runs in the background. |
HaoranYi
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is useful to know what slot clean is working on.
Summary of Changes
Add slot metric to clean stat.
Fixes #