-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offset command line option to store-histogram #3296
base: master
Are you sure you want to change the base?
Conversation
Not sure about bin widths -- do they have to be adjusted too? |
I don't care about bin widths. Bins were just trying to break them up into some smaller groups. |
eprintln!("storages: {}", info.len()); | ||
eprintln!("lowest slot: {min}"); | ||
eprintln!("highest slot: {max_inclusive}"); | ||
eprintln!("slot range: {}", max_inclusive - min + 1); | ||
eprintln!( | ||
"outside of epoch: {}", | ||
info.iter() | ||
.filter(|x| x.0 < max_inclusive - 432_000) | ||
.filter(|x| x.0 < max_inclusive - outside_slot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is no longer an "epoch".
Maybe change it to something like "ancient boundary"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this print says "how many slots are there beyond ancient boundary"? How about this?
.filter(|x| x.0 < max_inclusive - outside_slot) | |
eprintln!( | |
"ancient boundary: {}, num_of_slots_beyond_ancient_bondary: {}", outside_slot, | |
info.iter() | |
.filter(|x| x.0 < max_inclusive - outside_slot).count() | |
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this is getting there. here is the output of a master 100k offset machine:
@dmakarov jw13 has this pulled down from your branch and built. the goal of this summary middle section is non-ancient, ancient all grouped in 1 bin each. Right now, that offset (at least printed) is 432k. The last one (10k) can be deleted completely, I think. |
@dmakarov also, I said I didn't care about bin size, but it should end up with a bin boundary at the ancient/non-ancient boundary:
In my case, with 100k offset, this should be 332000 as a boundary number here that is 'ancient' |
I added logic to split a bin on the ancient boundary. |
maybe should be left for another pr? |
Problem
Boundary of ancient slots is hard-coded and not configurable.
Recent mnb changes make the offset 100k by default. Would be great if histogram allowed specifying the boundary between ancient and non-ancient.
Summary of Changes
Add a command line option to pass a value of offset from which the epoch boundary should be computed.