Support dead slot notification in geyser #3163
Open
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijunwangs
force-pushed
the
support_dead_slot_notification_in_geyser
branch
from
8b09500
to
a6cf0e1
Compare
lijunwangs
force-pushed
the
support_dead_slot_notification_in_geyser
branch
from
a6cf0e1
to
db5ad2b
Compare
bw-solana
reviewed
Oct 22, 2024
| @@ -328,6 +328,9 @@ pub enum SlotStatus { | |||
|
|
|||
| /// A new bank fork is created with the slot | |||
| CreatedBank, | |||
|
|
|||
| /// A slot is marked dead | |||
| Dead, | |||
There was a problem hiding this comment.
Should we include the reason for marking the slot dead as a string in this enum?
| @@ -37,6 +37,10 @@ impl SlotStatusNotifierInterface for SlotStatusNotifierImpl { | |||
| fn notify_created_bank(&self, slot: Slot, parent: Slot) { | |||
| self.notify_slot_status(slot, Some(parent), SlotStatus::CreatedBank); | |||
| } | |||
|
|
|||
| fn notify_slot_dead(&self, slot: Slot, _error: String) { | |||
There was a problem hiding this comment.
It would be nice to include this error string.. maybe embed it in the SlotStatus enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the 4th part to support more slot status notification type in geyser: Dead slot.
Summary of Changes
Link SlotStatusNotifier in replay stage on Dead slot.
Tests: tested change with Postgres geyser plugin and confirming the Dead slot being received.
Fixes #
#2957