-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dead slot notification in geyser #3163
base: master
Are you sure you want to change the base?
Support dead slot notification in geyser #3163
Conversation
8b09500
to
a6cf0e1
Compare
a6cf0e1
to
db5ad2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Left 1 consideration
@@ -328,6 +328,9 @@ pub enum SlotStatus { | |||
|
|||
/// A new bank fork is created with the slot | |||
CreatedBank, | |||
|
|||
/// A slot is marked dead | |||
Dead, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include the reason for marking the slot dead as a string in this enum?
@@ -37,6 +37,10 @@ impl SlotStatusNotifierInterface for SlotStatusNotifierImpl { | |||
fn notify_created_bank(&self, slot: Slot, parent: Slot) { | |||
self.notify_slot_status(slot, Some(parent), SlotStatus::CreatedBank); | |||
} | |||
|
|||
fn notify_slot_dead(&self, slot: Slot, _error: String) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to include this error string.. maybe embed it in the SlotStatus enum
Problem
This is the 4th part to support more slot status notification type in geyser: Dead slot.
Summary of Changes
Link SlotStatusNotifier in replay stage on Dead slot.
Tests: tested change with Postgres geyser plugin and confirming the Dead slot being received.
Fixes #
#2957