-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow deserializing UiAccount rent epoch > u64 #2951
base: master
Are you sure you want to change the base?
Conversation
I'd also like to back port this fix to 1.16.* crates if possible |
Sorry @jordy25519 but what exactly is the motivation here? Everywhere in the source, EDIT: Oops, maybe I should read the linked issue. I'm still curious where that value comes from, though? It's 385 above |
not sure right channel to broadcast to RPC providers and get this fixed as it shouldn't happen. for completeness, more examples:
{
"id": 1,
"jsonrpc": "2.0",
"result": {
"context": {
"apiVersion": "1.18.22",
"slot": 290645650
},
"value": {
"data": [
"KLUv/SAAAQAA",
"base64+zstd"
],
"executable": false,
"lamports": 2088540689624,
"owner": "11111111111111111111111111111111",
"rentEpoch": 18446744073709552000,
"space": 0
}
}
} |
accidentally closed |
Hey @jordy25519 sorry for delay here. While I can appreciate the fact that When trying to reproduce some of the linked issues (magicblock-labs/Solana.Unity-Core#49 and gagliardetto/solana-go#172), using the RPC from I'm going to move conversation to the issue for now, to see if we can narrow down where this issue might be rooted. |
Problem
allows deserializing larger max rent epoch values
closes #2950
Summary of Changes
deserialize rent epoch as u128 before clamping to u64::MAX