Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Misplaced icons on linux builds #398

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Bugfix/Misplaced icons on linux builds #398

merged 1 commit into from
Dec 5, 2023

Conversation

D-Brox
Copy link
Contributor

@D-Brox D-Brox commented Dec 5, 2023


  • I understand that contributing to this repository will require me to agree with the CLA

Description

This PR fixes the missing icons Deb, Appimage and Snap builds due to an old electron-builder bug (electron-userland/electron-builder#5294) by referencing a folder instead of a file.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Fixes #389

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

Copy link

github-actions bot commented Dec 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@D-Brox
Copy link
Contributor Author

D-Brox commented Dec 5, 2023

I have read the CLA Document and I hereby sign the CLA

@ra3orblade ra3orblade merged commit 1585267 into anyproto:main Dec 5, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@ra3orblade
Copy link
Contributor

ra3orblade commented Dec 5, 2023

You forgot to change windows icon path accordingly:

"win": {
			"sign": "./electron/hook/sign.js",
			"target": "nsis",
			"icon": "electron/img/icons/256x256.png",

@fuksman
Copy link
Member

fuksman commented Dec 6, 2023

@any contributor @D-Brox code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Icon on Anytype Linux (Deb, Appimage, Snap)
3 participants