GO-4442 add weights #1789
Open
GO-4442 add weights #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmetrikat
reviewed
Nov 6, 2024
Comment on lines
+16
to
+17
| // Finish performs the | ||
| Finish() error |
There was a problem hiding this comment.
what's the missing part of the comment?
…o-4442-add-weights # Conflicts: # go.mod # go.sum
cheggaaa
reviewed
Nov 8, 2024
| sort.Slice(resultsByObjectId[objectId], func(i, j int) bool { | ||
| if bleveResults[i].Score > bleveResults[j].Score { | ||
| cur := resultsByObjectId[objectId] | ||
| sort.Slice(cur, func(i, j int) bool { |
There was a problem hiding this comment.
slices.SortFunc should be faster
cheggaaa
reviewed
Nov 8, 2024
|
|
||
| byteToRuneIndex := make([]int, len(highlight)+1) | ||
| for i := range byteToRuneIndex { | ||
| byteToRuneIndex[i] = utf8.RuneCountInString(highlight[:i]) |
There was a problem hiding this comment.
you should work with utf16 (and please, check it in other fts places)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?