GO-4179 initial page web-publishing #1681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarkone
force-pushed
the
go-4179-prepare-page-export
branch
from
9b54396
to
3414043
Compare
fat-fellow
changed the title
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
deff7
reviewed
Oct 14, 2024
| @@ -0,0 +1,146 @@ | |||
| package publish | |||
core/publish/service.go
Outdated
| return CName | ||
| } | ||
|
|
||
| func (s *service) publishById(ctx context.Context, spaceId, pageObjId string) (res PublishResult, err error) { |
There was a problem hiding this comment.
right, this one supposed to use id but not string from client. Removed for now in b5105a6
core/publish.go
Outdated
| func (mw *Middleware) ObjectPublish(ctx context.Context, req *pb.RpcObjectPublishRequest) *pb.RpcObjectPublishResponse { | ||
| publishService := getService[publish.Service](mw) | ||
|
|
||
| res, _ := publishService.Publish(ctx, req.SpaceId, req.ObjectId) |
json was generated by castom code from mapping, I don't know how to do the same in easy way in middleware yet. So for now I'm just sending the whole object instead of id.
zarkone
force-pushed
the
go-4179-prepare-page-export
branch
from
3414043
to
a5be0a3
Compare
|
addressed comments and closing this PR in favor of #1684 -- will serve as an epic for feature |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.