Multiselect-dropdown-foreground-background #590
Conversation
…e input field after deletion
popover now also has a background property as a side effect
for more information, see https://pre-commit.ci
| @property | ||
| def foreground(self): | ||
| return self._foreground | ||
|
|
||
| @foreground.setter | ||
| def foreground(self, value): | ||
| self._foreground = value | ||
| self.label.foreground = self.icon_checked.foreground = value | ||
|
|
There was a problem hiding this comment.
Can we follow the code style of the component and keep props in the _props dict.
Same for other components in this PR.
client_code/popover.py
Outdated
| @@ -330,6 +334,9 @@ def init_popover(self, element): | |||
| element.setAttribute("ae-popover", "") | |||
| element.setAttribute("ae-popover-id", self.id) | |||
|
|
|||
| if self.background: | |||
| _S(element).css("background-color", self.background) | |||
There was a problem hiding this comment.
Let's not use jquery when vanilla JavaScript will do just fine. Likewise for other uses of jquery
| @foreground.setter | ||
| def foreground(self, value): | ||
| self._foreground = value | ||
| if value and self._props_initialized: |
There was a problem hiding this comment.
It doesn't seem like it's possible to remove background/foreground
There was a problem hiding this comment.
did that by just removing the conditional checks (for the most part)
| pop(self._select_btn, "destroy") | ||
| popover( | ||
| self._select_btn, | ||
| self._dd, | ||
| placement="bottom-start", | ||
| arrow=False, | ||
| delay=0, | ||
| animation=False, | ||
| trigger="manual", | ||
| max_width="fit-content", | ||
| background=value, | ||
| ) |
There was a problem hiding this comment.
This feels a bit of a strange place to do popover creation.
There was a problem hiding this comment.
I fixed this by changing the popover so that the popover function returns the Popover object and adding background changing to the fui module's auto_update function
2. used the _props dict where relevant 3. Modified popover and fui so I could change the background color without recreating 4. background/foreground can now be removed 5. items can be added with the write foreground color
for more information, see https://pre-commit.ci
…should add foreground to it too.
for more information, see https://pre-commit.ci
client_code/popover.py
Outdated
| fui.auto_update( | ||
| _get_popper_element(self.popper), | ||
| self.dom_popover, | ||
| placement=self.placement, | ||
| arrow=self.dom_arrow if self.arrow else None, | ||
| foreground=self.foreground, | ||
| background=value, | ||
| ) |
There was a problem hiding this comment.
I don't think floating ui needs to handle background or foreground. We give fui the floating element so the Popover class can handle background and foreground and fui doesn't need to get involved.
There was a problem hiding this comment.
That's true, I hadn't considered that, but just simplified it with that :)
…o the popover file; removed unrelated changes to progress bars from other pull request
Implements Feature #380 for background and foreground of the multiselect dropdown.
The same foreground and background are applied to the exterior and interior of the dropdown, as well as the checked icon.
The popover can also now have a background since this is how the multiselectdropdown is implemented