Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: use m3 beta theme colors #579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

theme: use m3 beta theme colors #579

wants to merge 1 commit into from

Conversation

s-cork
Copy link
Collaborator

@s-cork s-cork commented Nov 27, 2024 •
edited
Loading

Given that this is breaking - we might want to merge any outstanding PRs
bump the version
merge this breaking change
then bump the version again

@s-cork s-cork changed the title Fix variant bug and use m3 beta theme colors theme: use m3 beta theme colors Nov 27, 2024
@s-cork
Copy link
Collaborator Author

s-cork commented Nov 27, 2024

I guess we can also remove other deprecations before a major version bump required by this PR

@meatballs
Copy link
Member

Sounds good to me:

  • Bump the minor version
  • Remove the deprecations and merge this
  • Bump the major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meatballs meatballs meatballs approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-cork @meatballs