fix: render maxLines text correctly after render twice #3089
Conversation
|
你好 @Alexzjt，非常感谢你的贡献. Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
WalkthroughThis PR addresses a bug related to rendering text with a maximum number of lines ( Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| @@ -856,7 +856,7 @@ export abstract class BaseCell<T extends SimpleBBox> extends Group { | |||
|
|
|||
| const maxLines = Math.max( | |||
| 1, | |||
| Math.floor((displayHeight - padding) / lineHeight), | |||
| Math.round((displayHeight - padding) / lineHeight), | |||
There was a problem hiding this comment.
The change from Math.floor to Math.round in the calculation of maxLines may affect the rendering behavior. Ensure that this change does not introduce any unintended side effects, especially in edge cases where the line height and display height are close to each other.
| @@ -856,7 +856,7 @@ export abstract class BaseCell<T extends SimpleBBox> extends Group { | |||
|
|
|||
| const maxLines = Math.max( | |||
| 1, | |||
| Math.floor((displayHeight - padding) / lineHeight), | |||
| Math.round((displayHeight - padding) / lineHeight), | |||
There was a problem hiding this comment.
问题根因分析
- 数值截断逻辑矛盾
计算逻辑：(displayHeight - padding) / lineHeight = (61 - 16) / 16 = 2.8125 - 条件判断逻辑缺陷
isCustomHeight 触发条件：只有当 isCustomHeight = true 时才会执行计算，但代码中该参数默认值为 false，在二次渲染时外部传入 true，导致逻辑分歧。
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
#3087
🔍 Self-Check before the merge