-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复维值包含 '\t' 制表符时导致复制到 Excel 中数据错列的问题 #3085
Conversation
你好 @lijinke666,非常感谢你的贡献. Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
Walkthrough此PR修复了在复制或导出数据到Excel时,维值中包含制表符( Changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3085 +/- ##
==========================================
+ Coverage 75.77% 79.80% +4.03%
==========================================
Files 257 211 -46
Lines 11994 11628 -366
Branches 2464 2618 +154
==========================================
+ Hits 9088 9280 +192
+ Misses 1398 781 -617
- Partials 1508 1567 +59 ☔ View full report in Codecov by Sentry. |
Size Change: +119 B (+0.02%) Total Size: 619 kB
ℹ️ View Unchanged
|
🎉 This PR is included in version @antv/s2-v2.1.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
复制/导出时会在文本的两侧中增加制表符,用于在 Excel 中展示, 兼容极端情况,防止维值中本身就存在制表符的情况,如:“成都市\t” => "成都市\t\t" 导致错列
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge