-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复存在字段标记的 icon 时, 紧凑模式列宽计算错误出现省略号的问题 #2920
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +120 B (+0.04%) Total Size: 329 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2920 +/- ##
==========================================
+ Coverage 75.77% 80.81% +5.04%
==========================================
Files 257 180 -77
Lines 11994 10425 -1569
Branches 2464 2362 -102
==========================================
- Hits 9088 8425 -663
+ Misses 1398 553 -845
+ Partials 1508 1447 -61 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version @antv/s2-v2.0.0-next.29 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
问题: 计算列宽时只考虑了文本的宽度, 未考虑 icon 的场景, 导致出现省略号
该问题在 1.x 中 #2673 已修复, 同步代码时漏掉了相关逻辑
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge