feat: 明细表新增空数据占位符能力 #2729
Merged
feat: 明细表新增空数据占位符能力 #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: s2Options.placeholder 配置更改为 cell 和 empty
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
|
Size Change: +880 B (+0.28%) Total Size: 321 kB
ℹ️ View Unchanged
|
lijinke666
commented
May 17, 2024
| @@ -1029,9 +1031,9 @@ export abstract class BaseFacet { | |||
|
|
|||
| return { | |||
| maxX: (isContentMode ? maxX : width) - this.scrollBarSize, | |||
| maxY: isContentMode ? maxY : height - this.scrollBarSize, | |||
| maxY: (isContentMode ? maxY : height) - this.scrollBarSize, | |||
There was a problem hiding this comment.
这里应该是忘记写括号了, 会导致滚动条在容器外面
wjgogogo
approved these changes
May 17, 2024
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @antv/s2-react-v2.0.0-next.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
📝 Description
TODO:
BREAKING CHANGE: s2Options.placeholder 配置更改为 cell 和 empty
const s2Options = { - placeholder: "-", + placeholder: { + cell: '-' + } }const s2Options = { + placeholder: { + empty: { + icon: 'Empty', + description: '暂无数据' + } + } }🖼️ Screenshot
🔗 Related issue link
close #1946
🔍 Self-Check before the merge