Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test:补充一些新功能单测 & 更新某些旧单测快照 #2341

Closed
wants to merge 52 commits into from

Conversation

NoobNotN
Copy link
Collaborator

@NoobNotN NoobNotN commented Sep 8, 2023

👀 PR includes

🔧 Chore

  • Test case

📝 Description

  • 更新了 React 包的一个快照,变动内容为 Node 增加了一个 isTotalRoot 字段

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

JuZe and others added 30 commits August 24, 2023 16:27
…otalsDimGroup

# Conflicts:
#	packages/s2-core/package.json
…otalsDimGroup

# Conflicts:
#	packages/s2-core/scripts/test-live.mjs
…otalsDimGroup

# Conflicts:
#	packages/s2-core/scripts/test-live.mjs
JuZe added 19 commits September 4, 2023 17:45
…otalsDimGroup

# Conflicts:
#	packages/s2-core/CHANGELOG.md
…otalsDimGroup

# Conflicts:
#	packages/s2-core/CHANGELOG.md
# Conflicts:
#	packages/s2-core/__tests__/unit/data-process/new-total-spec.tsx
#	packages/s2-core/src/data-set/pivot-data-set.ts
#	s2-site/examples/analysis/totals/demo/dimension-group.ts
# Conflicts:
#	packages/s2-core/__tests__/unit/data-process/new-total-spec.tsx
#	packages/s2-core/src/data-set/pivot-data-set.ts
#	s2-site/examples/analysis/totals/demo/dimension-group.ts
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview Sep 8, 2023 2:29am

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 78.91% and project coverage change: -0.60% ⚠️

Comparison is base (2f3dfc4) 77.02% compared to head (4f44045) 76.42%.
Report is 382 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #2341      +/-   ##
==========================================
- Coverage   77.02%   76.42%   -0.60%     
==========================================
  Files         234      241       +7     
  Lines       11504    12569    +1065     
  Branches     2445     2701     +256     
==========================================
+ Hits         8861     9606     +745     
- Misses       1268     1372     +104     
- Partials     1375     1591     +216     
Files Changed Coverage Δ
packages/s2-core/src/cell/merged-cell.ts 34.78% <ø> (-1.59%) ⬇️
packages/s2-core/src/common/constant/index.ts 90.47% <ø> (-0.60%) ⬇️
packages/s2-core/src/data-set/base-data-set.ts 93.93% <ø> (+26.19%) ⬆️
packages/s2-core/src/facet/header/row.ts 77.77% <0.00%> (-7.41%) ⬇️
...ckages/s2-core/src/interaction/event-controller.ts 85.60% <ø> (+2.84%) ⬆️
...ackages/s2-core/src/interaction/range-selection.ts 70.11% <ø> (-0.26%) ⬇️
packages/s2-core/src/interaction/root.ts 83.98% <ø> (-1.43%) ⬇️
...kages/s2-core/src/interaction/row-column-resize.ts 86.70% <ø> (+0.17%) ⬆️
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.30% <ø> (-1.94%) ⬇️
packages/s2-core/src/sheet-type/spread-sheet.ts 77.57% <ø> (-3.16%) ⬇️
... and 94 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@lijinke666
Copy link
Member

rebase 一下 alpha, 或者基于 alpha 建一个新分支

@NoobNotN NoobNotN closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants