-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tooltip): 重构 tooltip API 命名 #2271
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -29 B (0%) Total Size: 320 kB
ℹ️ View Unchanged
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## next #2271 +/- ##
==========================================
+ Coverage 75.77% 76.77% +1.00%
==========================================
Files 257 268 +11
Lines 11994 12202 +208
Branches 2464 2484 +20
==========================================
+ Hits 9088 9368 +280
+ Misses 1398 1296 -102
- Partials 1508 1538 +30
☔ View full report in Codecov by Sentry. |
This reverts commit e01dc46.
🎉 This PR is included in version @antv/s2-v2.0.0-next.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v2.0.0-next.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-vue-v2.0.0-next.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🎨 Enhance
📝 Description
配置
api 都在
tooltip
命名空间下, 命名可以简化, 并且修改语义visible
或者show
,open
之类的命名更适用于<Modal/>
,<Tooltip/>
这种组件的方式, 为 true 就显示, false 就关闭,而对于我们的 tooltip,
showTooltip
实际含义表示是否开启 tooltip 的能力, 而不是是否显示, 不管 true/false 都是默认关闭, 在 hover/click 的时候才会显示, 所以会有歧义方法
showSingleTips 和 onlyMenu 命名过于抽象, 和实际做的事情不符, 重命名为更表意的
BUG 修复 - 暗黑主题适配问题
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge