-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 文本和图标的条件格式支持主题配置 #2267
feat: 文本和图标的条件格式支持主题配置 #2267
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -84 B (0%) Total Size: 320 kB
ℹ️ View Unchanged
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## next #2267 +/- ##
==========================================
+ Coverage 75.77% 76.78% +1.01%
==========================================
Files 257 268 +11
Lines 11994 12201 +207
Branches 2464 2484 +20
==========================================
+ Hits 9088 9369 +281
+ Misses 1398 1294 -104
- Partials 1508 1538 +30
☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version @antv/s2-v2.0.0-next.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @antv/s2-react-v2.0.0-next.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
✨ Feature
📝 Description
背景
fontWeight
, 主题配置又只能对所有单元格生效, 有点无解icon
和fill
, 缺失修改字体大小, 对齐方式, 透明度等能力layoutDataPosition
, 动态的修改特定行为小计节点达到加粗的效果解法
方式1: 让 S2 主题配置增加动态 hook 的能力, 但是这样和条件格式的定位有点冲突
方式2: 主题配置 = 全局通用的配置, 条件格式 = 满足特定数据/场景的自定义配置
方式3: 走 自定义单元格, 不过对于用户的技术能力有一定要求, 增加理解成本
综上所述: 采用 方式2 - 在条件格式的配置基础上, 支持额外的主题配置 API
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge