Fix #4309: memory leaks in C++ runtime #4374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pyxherb <[email protected]>
ghost
changed the title
Signed-off-by: pyxherb <[email protected]>
ghost
changed the title
|
This also fixes memory leaks in ATNDeserializationOptions. |
|
This modification has been tested with valgrind on Linux and no memory leaks were detected, whereas there were leaks before. It's very impressive, and I hope it can be merged into the main branch as soon as possible. |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static data of lexers and parsers will never be released, this will cause numerous memory leak prompts to appear after the program exits (see the logs in #4309).
This PR uses
unique_ptrinstead of raw pointer for static data to avoid this problem (the static data will be released automatically after the program exits).