Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases #21

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

test cases #21

wants to merge 16 commits into from

Conversation

depaolim
Copy link

@depaolim depaolim commented Nov 4, 2023

Just a prototype test case using "nc"
(Obviously it would have also made sense to build a client in Python, but I wanted to limit the test to the behavior described in the video, without adding features)
During the implementation of the test case, which obviously runs faster than a user test, the need arose to insert a "sleep" command... which is a smell and should turn on some light bulbs

@antirez
Copy link
Owner

antirez commented Nov 10, 2023

Hey. Still premature because it makes more sense to test it when the implementation is a bit more complete. Many things will change since this program is designed to show programming, is not a "real" project. I'll keep this open as a reminder that we should add some testing, and maybe in Python indeed :)

@depaolim
Copy link
Author

Hi! Thanks for your feedback and for the interesting project! (you gave me the idea to try a mini porting to python)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants