Configurable mirroring #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2020 18:04
Users of this role can change the policy content without changing its name, which means Ansible will simply update it instead of creating a new, potentially conflicting policy
Allow to disable mirroring
jpiron
added a commit
to jpiron/ansible-role-rabbitmq
that referenced
this pull request
Aug 17, 2020
…upport_ Fix cluster name support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Another PR, this time about mirroring. I would like to be able to configure how my queue are mirrored, so I defined the policy in a variable. Also, I used the Ansible
rabbitmq_policyresource instead of arabbitmqctlcommand. The default value matches the policy you had except I changed the name to be more neutral (so that users can modify the policy content without changing its name, meaning Ansible will update it instead of replacing it).I don't think this is a breaking change as the new policy as the same behaviour, but what do you think?
Also, users can override the policy to an empty var if they don't want mirroring at all.