Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user creation #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alsyia
Copy link

@alsyia alsyia commented Jan 14, 2020

Hi,

Thanks for this role! I've been using it for a few days and I noticed a few things about how RabbitMQ users are managed:

  • Creation/deletion tasks are run on every node, this can lead to a race condition if nodes are clustered: all nodes thinks they should add/remove the user but only the first one gets to do it, others raise an error
  • Also, the password is logged by Ansible during the creation like this:
ok: [my-rabbit-server] => (item={'password': 'my-password', 'tags': 'administrator', 'user': 'my-user'})

This PR contains fixes for these two points, do you think it could be merged?

Thank you!

P.S. : Probably more PRs to come :)

Wenceslas des Déserts added 2 commits January 14, 2020 15:42
This is to avoid race conditions when the task is run on each node of the cluster
Output contains the user's password
@jpiron
Copy link

jpiron commented Jul 15, 2020

Hi any feedback on this ?

jpiron pushed a commit to jpiron/ansible-role-rabbitmq that referenced this pull request Aug 14, 2020
…upport_

Add support for defining cluster name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants