add update example #364
Open
add update example #364
+141
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxyucs
added
kind/improvement
Signed-off-by: Xiangyu Wang <[email protected]>
wxyucs
force-pushed
the
add-update-example
branch
from
0dcc7a1 to
d56c126
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 90.81% 90.92% +0.11%
==========================================
Files 133 133
Lines 8429 8445 +16
==========================================
+ Hits 7655 7679 +24
+ Misses 774 766 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
jiaweizone
reviewed
Jan 22, 2025
| ->Owner(false); | ||
|
|
||
| // try to update determines by the distance between the new vector and the old vector | ||
| if (auto update_vector = index->UpdateVector(update_id, update_dataset, false); |
There was a problem hiding this comment.
update_vector -> update_status ?
| abort(); | ||
| } else if (*update_vector) { /* updated, new vector is near to the old vector */ | ||
| std::cout << "updated, new vector is near to the old vector" << std::endl; | ||
| } else { /* not update, new vector is far away from the old vector */ |
There was a problem hiding this comment.
Q: default is in place update ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.