fix the issue caused by passing in invalid vectors #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 90.94% 91.03% +0.09%
==========================================
Files 133 133
Lines 8459 8459
==========================================
+ Hits 7693 7701 +8
+ Misses 766 758 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
LHT129
reviewed
Jan 22, 2025
inabao
force-pushed
the
add-tests-for-nan-vector
branch
from
a58eeda to
83fbed5
Compare
wxyucs
reviewed
Jan 22, 2025
added 2 commits
January 22, 2025 19:23
Signed-off-by: jinjiabao.jjb <[email protected]>
Signed-off-by: jinjiabao.jjb <[email protected]>
inabao
force-pushed
the
add-tests-for-nan-vector
branch
from
83fbed5 to
dcfca3c
Compare
jiaweizone
approved these changes
Jan 22, 2025
| for (int i = 0; i < sample_size; ++i) | ||
| { | ||
| auto norm = get_norm(train_data + i * train_dim, train_dim); | ||
| if (std::abs(norm) < 1e-6 || std::isnan(norm)) { |
There was a problem hiding this comment.
Ok, add validate check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #360