support safe update #308
Merged
support safe update #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawnShawnYou
requested review from
inabao,
wxyucs,
LHT129 and
jiaweizone
as code owners
Closed
ShawnShawnYou
commented
Jan 9, 2025
| LOG_ERROR_AND_RETURNS(ErrorType::INVALID_ARGUMENT, | ||
| fmt::format("failed to pretrain(invalid argument): base tag id " | ||
| "({}) doesn't belong to index", | ||
| base_tag_id)); |
There was a problem hiding this comment.
a minor fix: error message "bas tag id" to "base tag id"
ShawnShawnYou
commented
Jan 9, 2025
| * @return result indicates whether the update operation is successful. | ||
| */ | ||
| virtual tl::expected<bool, Error> | ||
| UpdateVector(int64_t id, const DatasetPtr& new_base, bool need_fine_tune = false) { | ||
| UpdateVector(int64_t id, const DatasetPtr& new_base, bool force_update = false) { |
There was a problem hiding this comment.
p.s. We are not responsible for the consequences of this interface if the user specifies force_update = true
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 49.75% 49.81% +0.06%
==========================================
Files 331 335 +4
Lines 32701 33124 +423
Branches 4129 4190 +61
==========================================
+ Hits 16271 16502 +231
- Misses 15568 15755 +187
- Partials 862 867 +5
Continue to review full report in Codecov by Sentry.
|
jiaweizone
reviewed
Jan 9, 2025
inabao
reviewed
Jan 9, 2025
| for (int i = 0; i < result.value()->GetDim(); i++) { | ||
| float neighbor_dist = | ||
| std::reinterpret_pointer_cast<hnswlib::HierarchicalNSW>(alg_hnsw_) | ||
| ->getDistanceByLabel(result.value()->GetIds()[i], new_base_vec); |
There was a problem hiding this comment.
#309 provides a batch interface, which can be considered for use later on
There was a problem hiding this comment.
fix this in other pr?
Signed-off-by: zhongxiaoyao.zxy <[email protected]>
ShawnShawnYou
force-pushed
the
support-safe-update
branch
from
652697a to
9ef9613
Compare
ShawnShawnYou
added
kind/improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #225