-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Ansible Lint Action against custom_json.yml #54
base: main
Are you sure you want to change the base?
Conversation
👋 Hey, looks fine but I'm not sure I understand intent. Is this something to test out ansible-lint or the playbooks? Or is it for testing out the github action? Would you want to move towards running this against all playbooks in this project? |
It's testing playbooks + also dogfooding Ansible Lint and an Action I've built. |
I think that running lint on all these playbooks is a great idea, but I'd like to start out getting them all converted, and also running that against PRs. I don't fully see how this gets us there, or what's left to do. |
@webknjaz |
currently only supports linting one file specified by ACTION_PLAYBOOK_NAME in https://github.com/ansible/ansible-lint-action/blob/master/entrypoint.sh . In future we will add directory support. |
@webknjaz can you put that comment in the file so future person knows where to look? #54 (comment) |
What file? |
FTR, here's a marketplace page of the action: https://github.com/marketplace/actions/ansible-lint |
FWIW there's Git blame + the PR link will be in the merge commit so it's very easy to track it back here. |
I feel like this would be a lot more useful if it could target multiple playbooks. I would not have a problem applying the policies to all of them. |
@AlanCoding I say let's give it a whirl as is and ask for directory support |
I'm okay with adding directory support. Just don't have time to do it right now. But the repo is open so feel free to send a PR there :) Currently, it kinda supports looking up all |
No description provided.