pytest: Custom marker for GitHub #572
Conversation
Created custom marker for skipping test if GitHub issue/pull is open. Signed-off-by: Abhijeet Kasurde <[email protected]>
Akasurde
force-pushed
the
github_issue_marker
branch
from
52f3ee8
to
e7f769e
Compare
| gh_markers = [mark.args[0] for mark in item.iter_markers(name="github")] | ||
| if gh_markers: | ||
| issue_url = gh_markers[0] | ||
| with urllib.request.urlopen(issue_url) as f: |
There was a problem hiding this comment.
Does this require using the API endpoint for an Issue?
There was a problem hiding this comment.
Yes. You will need to specify the marker like this -
import pytest
@pytest.mark.github('https://api.github.com/repos/ansible/receptor/issues/441')
def test_c():
print("This is Test C")I choose this routine in order to avoid additional dependency on third-party library.
There was a problem hiding this comment.
we can simplify the logic further to specify only the issue number or pull request number. But for starters, I think this OK.
There was a problem hiding this comment.
I think this is pretty difficult to use. Normally you'd just visit an issue in your browser. We should be able to copy / paste that URL instead of having to construct this API endpoint. We use https://github.com/jlaska/pytest-github in other projects, so we're not maintaining anything extra by also using it here.
Created custom marker for skipping test if GitHub issue/pull is open.
Fixes: #495