Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receptorctl assert invalid work cmd #447

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

thenets
Copy link
Member

@thenets thenets commented Oct 18, 2021

(it's only the last commit. The other files are from other PR #445)

Test for:

Depends on:

cc: @AlanCoding

@thenets thenets force-pushed the receptorctl-assert-invalid-work-cmd branch from 7f91f6a to e01dc01 Compare October 20, 2021 08:37
@thenets
Copy link
Member Author

thenets commented Oct 20, 2021

@shanemcd problem solved, I believe

@thenets thenets force-pushed the receptorctl-assert-invalid-work-cmd branch from e01dc01 to a8ad649 Compare October 20, 2021 21:31
@thenets
Copy link
Member Author

thenets commented Oct 20, 2021

Test created. Currently failing, cause the work cancel command do not return a non-zero exit code when fail.

@thenets
Copy link
Member Author

thenets commented Nov 17, 2021

@shanemcd @fosterseth this PR will never be auto-merged.
The test is failing because the code is wrong. We need to have a flow to merge and fix broken tests.

@thenets
Copy link
Member Author

thenets commented Nov 17, 2021

I need to finish this issue first:

Then I'll be able to rebase and merge without having the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants