-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug log for work unit payloads #1146
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## devel #1146 +/- ##
==========================================
+ Coverage 42.99% 43.74% +0.74%
==========================================
Files 33 36 +3
Lines 6612 7265 +653
==========================================
+ Hits 2843 3178 +335
- Misses 3530 3845 +315
- Partials 239 242 +3
... and 7 files with indirect coverage changes
|
Great work on this, First idea, lets change Imagine level 1 we just print something like "Unix message" , "Network message". Let me know what you think. The next thing to think about is code reusability (might be outside the scope of this PR) |
Thinking more on this, in my example maybe we should switch the level 2 and 3 😂 |
Co-authored-by: AaronH88 <[email protected]>
@@ -62,6 +62,27 @@ Log level | |||
- Error | |||
- string | |||
|
|||
Add payload debuging using `RECEPTOR_PAYLOAD_DEBUG=int` envorment variable and using log level debug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Env var is called RECEPTOR_PAYLOAD_TRACE_LEVEL
not this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think it would be a good idea to replace everywhere where you have the word "debug" with the word "trace"
:header-rows: 1 | ||
:widths: auto | ||
|
||
* - Debug level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest "Tracing Level"
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Add debug log for work unit payloads using RECEPTOR_PAYLOAD_DEBUG env var
Control output:
Control status:
Execution output: