Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure bootstrap reqs are good #15733

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

AlanCoding
Copy link
Member

SUMMARY

Adds a regression test for what #15732 by @saito-hideki fixes

It should fail until that is merged.

This test is intended to be "lazy" and brutal in implementation. As you can see in this file, importing from libs like pip is fragile and tends to break. This should continue to work as long as we keep our file structures the same, and if someone changes it, then can come edit this test.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@AlanCoding
Copy link
Member Author

expected failure:

AssertionError: assert 'setuptools==69.0.2' == 'setuptools==75.6.0'
  
  - setuptools==75.6.0
  ?             ---
  + setuptools==69.0.2
  ?              +  ++
===============================

maybe I can do better. Might push another commit.

@AlanCoding
Copy link
Member Author

I like this now

  File "/awx_devel/awx/main/tests/functional/test_python_requirements.py", line 35, in test_bootstrap_consistent
    assert not different_requirements
AssertionError: assert not [('pip==21.2.4', 'pip==21.2.4'), ('setuptools==69.0.2', 'setuptools==75.6.0'), ('wheel==0.42.0', 'wheel==0.45.1'), ('cython==0.29.37', 'cython==3.0.11')]

@AlanCoding AlanCoding marked this pull request as ready for review January 13, 2025 18:48
@AlanCoding
Copy link
Member Author

The test result kept me honest here, I had an error and it was failing. But it should be good now. Will revisit again and hopefully merge when it passes.

Copy link

@AlanCoding AlanCoding merged commit fb12c83 into ansible:devel Jan 13, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants