Min value should be Decimal #15413
Open
Min value should be Decimal #15413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlanCoding
reviewed
Aug 23, 2024
| @@ -160,7 +160,7 @@ def __str__(self): | |||
| default=100, | |||
| editable=False, | |||
| ) | |||
| capacity_adjustment = models.DecimalField(default=Decimal(1.0), max_digits=3, decimal_places=2, validators=[MinValueValidator(0)]) | |||
| capacity_adjustment = models.DecimalField(default=Decimal(1.0), max_digits=3, decimal_places=2, validators=[MinValueValidator(Decimal(0.0))]) | |||
There was a problem hiding this comment.
Does this not require a new migration file?
There was a problem hiding this comment.
bash-5.1$ awx-manage makemigrations
No changes detected
Does not appear so
There was a problem hiding this comment.
Don't think it actually changes the datatype, but rather validator function in Django
There was a problem hiding this comment.
validators had some weird place in both the fields and the model Meta. Weird but possible.
kdelee
force-pushed
the
min-value-decimal
branch
from
ba37d71
to
80c179d
Compare
AlanCoding
approved these changes
Sep 5, 2024
|
A test could be nice too. |
kdelee
force-pushed
the
min-value-decimal
branch
from
80c179d
to
20a1df2
Compare
This hopefully resolves error message seen in logs sometimes about "should be Decimal type"
kdelee
force-pushed
the
min-value-decimal
branch
from
20a1df2
to
9ee487d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully resolves error message seen in logs sometimes about "should be Decimal type"
ISSUE TYPE
COMPONENT NAME