Incorrect capacity for remote execution nodes 14051 #14272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djyasin
force-pushed
the
incorrect_capacity_for_remote_execution_nodes_14051
branch
2 times, most recently
from
4dfde3e
to
72a56ea
Compare
AlanCoding
reviewed
Jul 24, 2023
AlanCoding
reviewed
Jul 24, 2023
djyasin
force-pushed
the
incorrect_capacity_for_remote_execution_nodes_14051
branch
from
e26202c
to
781892e
Compare
AlanCoding
reviewed
Jul 31, 2023
djyasin
force-pushed
the
incorrect_capacity_for_remote_execution_nodes_14051
branch
from
781892e
to
1caa711
Compare
AlanCoding
reviewed
Aug 1, 2023
awx/main/models/ha.py
Outdated
| @@ -354,7 +354,7 @@ def local_health_check(self): | |||
| except redis.ConnectionError: | |||
| errors = _('Failed to connect to Redis') | |||
|
|
|||
| self.save_health_data(awx_application_version, get_cpu_count(), get_mem_in_bytes(), update_last_seen=True, errors=errors) | |||
| self.save_health_data(self, awx_application_version, get_cpu_count(), get_mem_in_bytes(), update_last_seen=True, errors=errors) | |||
There was a problem hiding this comment.
self is automatically passed by python as the first argument in bound methods like these.
djyasin
force-pushed
the
incorrect_capacity_for_remote_execution_nodes_14051
branch
from
7e03efd
to
6d1c8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes issue #14051
Correct reporting for task container resource limits set (in k8s), revising the handling of execution nodes specifically.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION