AAP-10891 Apply AWX_TASK_ENV when performing credential plugin lookups #14271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamuniz
approved these changes
Jul 24, 2023
AlanCoding
force-pushed
the
plugin_proxy
branch
from
8783338
to
79fb155
Compare
AlanCoding
changed the title
AlanCoding
force-pushed
the
plugin_proxy
branch
from
aef93a4
to
34802c4
Compare
jay-steurer
approved these changes
Aug 23, 2023
relrod
approved these changes
Aug 23, 2023
djyasin
approved these changes
Aug 23, 2023
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In #11956 we seem to have expressed an intent to do this, but it slipped between the cracks, as it was only fixed for the test endpoint, making that behave differently than the actual lookups.
For other types of plugins, we do apply
AWX_TASK_ENVwhen running them (like notifications) and I think we were supposed to do the same here.ISSUE TYPE
COMPONENT NAME