Only push the production images for main repo #14261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanemcd
reviewed
Jul 18, 2023
.github/workflows/devel_images.yml
Outdated
|
|
||
| - name: Push AWX k8s image, only for upstream and feature branches | ||
| run: docker push ghcr.io/${OWNER_LC}/awx:${GITHUB_REF##*/} | ||
| if: github.repository == 'ansible/awx' |
There was a problem hiding this comment.
Can you relax this a bit? See
awx/.github/workflows/stage.yml
Line 24 in 1d7e54b
AlanCoding
force-pushed
the
will_the_real_prod_please_stand_up
branch
from
6fa51c3
to
15bb5df
Compare
shanemcd
approved these changes
Jul 19, 2023
jay-steurer
approved these changes
Jul 19, 2023
AlanCoding
added a commit
to AlanCoding/awx
that referenced
this pull request
Aug 10, 2023
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Forks were having errors pushing the
/awximage, as they should! Not just anything should be able to push tags to that. This adds a restriction to only do that for the AWX repo. There is concern whether this will work correctly for PRs... lucky for us this is a PR.ISSUE TYPE
COMPONENT NAME