Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update execution_nodes.md to follow changes for receptor_collection #14248

Closed
wants to merge 35 commits into from

Conversation

kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Jul 17, 2023

SUMMARY

related #14247

Update execution_nodes.md to follow following changes:

  • Copr repository is no longer used in new receptor collection
  • receptor_dependencies in group_vars/all.yml has been updated as python3-pip in this feature branch, and this causes error on RHEL 8 based OS since it's too old and causes error during Ansible Runner installation. (edit: will be fixed on the collection side by Check python version receptor-collection#47)
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Docs
AWX VERSION
# feature_hop-node branch
awx: 22.5.1.dev43+g7df570e9cd
ADDITIONAL INFORMATION

I'm sending this PR against feature_hop-node branch, since requirements.yml and group_vars/all.yml is updated on only in this branch.
The devel branch doesn't have the related issue, since its requirements.yml points old collection and group_vars/all.yml has old value.

@thedoubl3j
Copy link
Member

related ansible/receptor-collection#47

@kurokobo
Copy link
Contributor Author

kurokobo commented Jul 19, 2023

@thedoubl3j
Thanks for informing me, I didn't realize that there is a PR to fix dependency issue by collection side.
I have updated this PR here to just remove paragraph about Copr.

@kurokobo kurokobo changed the title docs: update execution_nodes.md to follow changes for receptor_collection and group_vars docs: update execution_nodes.md to follow changes for receptor_collection Jul 19, 2023
@fosterseth fosterseth force-pushed the feature_hop-node branch 5 times, most recently from 8474383 to 2f2392f Compare August 1, 2023 16:31
@kurokobo
Copy link
Contributor Author

kurokobo commented Aug 3, 2023

@thedoubl3j @fosterseth
Just to inform, I've rebased this with the latest feature_hop-node branch.

@kurokobo kurokobo mentioned this pull request Aug 9, 2023
1 task
fosterseth and others added 15 commits August 9, 2023 11:59
Add Disconnected link state

introspect_receptor_connections is a periodic
task that examines active receptor connections
and cross-checks it with the InstanceLink info.

Any links that should be active but are not
will be put into a Disconnected state. If
active, it will be in an Established state.

UI - Add hop creation and peers mgmt (ansible#13922)

* add UI for mgmt peers, instance edit and add

* add peer info on detail and bug fix on detail

* remove unused chip and change peer label

* rename lookup, put Instance type disable on edit

---------

Co-authored-by: tanganellilore <[email protected]>
Add disconnected link state topology
add peer listener_port validation and update install bundle if listener_port is defined or not defined.
add tests for calling write_receptor_config

add write_receptor_config test

Do not set default listener_port on control node
Add hop node support to awx collections
- add peers and peers_from_control_nodes fields
- show new node_type "hop"
- add tests for adding hop nodes via collections

Co-authored-by: Seth Foster <[email protected]>
rename migration function set_peers_from_control_nodes_true to automatically_peer_from_control_plane
import settings and only run function if settings.IS_K8S is true
set listener_port for control nodes to None
use devel receptor-collection
djyasin and others added 18 commits August 9, 2023 11:59
inspect_established_receptor_connections should
not change link state is current state is Removing.

Other changes:
- rename inspect_execution_nodes to inspect_execution_and_hop_nodes
- Default link state is Adding
- Set min listener_port value to 1024
- inspect_established_receptor_connections now
runs as part of cluster_node_heartbeat task
Dynamically flipping from Established
to Disconnected is not the intended
usage of InstanceLink State.

- Link state starts in Adding and becomes
Established once any control node first sees the link
is in the status KnownConnectionCosts
API changes
- cannot change peers or enable
peers_from_control_nodes on VM deployments
- allow setting ip_address
- use ip_address over hostname in the generated
group_vars/all.yml
- Drop api/v2/peers endpoint

DB changes
- add ip_address unique constraint, but ignore "" entries

Other changes
- provision_instance should take listener_port option

Tests
- test that new controls doesn't disturb other peers
relationships
- test ip_address over hostname
Get rid of PeersSerializer and just use SlugRelatedField,
which should be more a straightforward approach.

Other changes:
- cleanup code related to the already-removed api/v2/peers
endpoint
- add "hybrid" node type into more instance_peers test cases
Add a check_peers_changed() utility method
to determine if peers in attrs matches
the current instance peers.

Other changes:
- Set ip_address default to "", and do not
allow null.
@fosterseth
Copy link
Member

cherry picked commit into the main hop node branch https://github.com/ansible/awx/pull/13904/commits
thank you!

@fosterseth fosterseth closed this Aug 28, 2023
@kurokobo kurokobo deleted the docs_execution_node branch August 28, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants