Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make target should not call make directly #13888

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

TheRealHaoLiu
Copy link
Member

@TheRealHaoLiu TheRealHaoLiu commented Apr 19, 2023

SUMMARY

https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html

make target should always call make with $(MAKE)

Recursive make commands should always use the variable MAKE, not the explicit command name ‘make’
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
awx: 22.1.1.dev21+g329fb88bbb.d20230419
ADDITIONAL INFORMATION

@TheRealHaoLiu
Copy link
Member Author

#13737

Copy link
Contributor

@jjwatt jjwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@TheRealHaoLiu TheRealHaoLiu merged commit f0badea into ansible:devel Apr 19, 2023
@TheRealHaoLiu TheRealHaoLiu deleted the correct-make-call-make branch April 19, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants