Skip to content

Commit

Permalink
remove test fields, linting fix
Browse files Browse the repository at this point in the history
  • Loading branch information
jessicamack committed Oct 2, 2024
1 parent 4c260e1 commit 5d30ede
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
8 changes: 1 addition & 7 deletions awx/conf/migrations/0011_remove_oidc_auth_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@

from django.db import migrations

Check warning on line 3 in awx/conf/migrations/0011_remove_oidc_auth_conf.py

View check run for this annotation

Codecov / codecov/patch

awx/conf/migrations/0011_remove_oidc_auth_conf.py#L3

Added line #L3 was not covered by tests

OIDC_AUTH_CONF_KEYS = [
'SOCIAL_AUTH_OIDC_KEY',
'SOCIAL_AUTH_OIDC_SECRET',
'SOCIAL_AUTH_OIDC_OIDC_ENDPOINT',
'SOCIAL_AUTH_OIDC_VERIFY_SSL'
]
OIDC_AUTH_CONF_KEYS = ['SOCIAL_AUTH_OIDC_KEY', 'SOCIAL_AUTH_OIDC_SECRET', 'SOCIAL_AUTH_OIDC_OIDC_ENDPOINT', 'SOCIAL_AUTH_OIDC_VERIFY_SSL']

Check warning on line 5 in awx/conf/migrations/0011_remove_oidc_auth_conf.py

View check run for this annotation

Codecov / codecov/patch

awx/conf/migrations/0011_remove_oidc_auth_conf.py#L5

Added line #L5 was not covered by tests


def remove_oidc_auth_conf(apps, scheme_editor):
Expand All @@ -16,7 +11,6 @@ def remove_oidc_auth_conf(apps, scheme_editor):


class Migration(migrations.Migration):

dependencies = [

Check warning on line 14 in awx/conf/migrations/0011_remove_oidc_auth_conf.py

View check run for this annotation

Codecov / codecov/patch

awx/conf/migrations/0011_remove_oidc_auth_conf.py#L13-L14

Added lines #L13 - L14 were not covered by tests
('conf', '0010_change_to_JSONField'),
]
Expand Down
4 changes: 1 addition & 3 deletions awx/sso/tests/functional/test_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def test_get_or_create_org_with_default_galaxy_cred_no_galaxy_cred(self, galaxy_
(False, True, False, 'social'),
],
)
def test_get_external_account(self, enable_ldap, enable_social, enable_enterprise, expected_results):
def test_get_external_account(self, enable_ldap, enable_enterprise, expected_results):
try:
user = User.objects.get(username="external_tester")
except User.DoesNotExist:
Expand Down Expand Up @@ -332,7 +332,6 @@ def test_get_external_account(self, enable_ldap, enable_social, enable_enterpris
('SOCIAL_AUTH_SAML_ENABLED_IDPS', True),
('RADIUS_SERVER', True),
('TACACSPLUS_HOST', True),
# Set some SOCIAL_SOCIAL_AUTH_OIDC_KEYAUTH_*_KEY settings
('SOCIAL_AUTH_AZUREAD_OAUTH2_KEY', True),
('SOCIAL_AUTH_GITHUB_ENTERPRISE_KEY', True),
('SOCIAL_AUTH_GITHUB_ENTERPRISE_ORG_KEY', True),
Expand All @@ -341,7 +340,6 @@ def test_get_external_account(self, enable_ldap, enable_social, enable_enterpris
('SOCIAL_AUTH_GITHUB_ORG_KEY', True),
('SOCIAL_AUTH_GITHUB_TEAM_KEY', True),
('SOCIAL_AUTH_GOOGLE_OAUTH2_KEY', True),
('SOCIAL_AUTH_OIDC_KEY', True),
# Try a hypothetical future one
('SOCIAL_AUTH_GIBBERISH_KEY', True),
# Do a SAML one
Expand Down

0 comments on commit 5d30ede

Please sign in to comment.