Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role import form: add overrides for namespace/role name #4763

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Dec 18, 2023

Follows #4508
Depends on ansible/galaxy_ng#2011
Forum: https://forum.ansible.com/t/new-ansible-galaxy-web-portal-where-is-all-the-old-role-admin-functionality/2304

20231218075425

Add alertnate namespace/role fields,
update placeholder to match,

(And fixup a bug from #4794 - npm install in the wrong place, to make the webpack config check pass)

TODO (later):
update github_user handling to use that new get_or_create logic
link from role import log to previous imports by role_id?

@github-actions github-actions bot added backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Dec 18, 2023
@himdel himdel added community comunity mode feature and removed backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Dec 18, 2023
@himdel himdel changed the title Role import form: add overrids for namespace/role name Role import form: add overrides for namespace/role name Dec 18, 2023
@himdel himdel marked this pull request as ready for review January 9, 2024 15:26
@himdel himdel merged commit 4812368 into ansible:master Jan 9, 2024
17 of 18 checks passed
@himdel himdel deleted the import-overrides branch January 9, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community comunity mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant