Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old ad #1872

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

remove old ad #1872

wants to merge 2 commits into from

Conversation

samccann
Copy link
Contributor

The Ad at the bottom left of docs pages stopped working when ansible.com was revamped, so ...time to remove it!

@samccann samccann added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch labels Sep 11, 2024
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than commenting, let's just delete the line. If we need to restore it, we have git history and can revert the commit.

Commenting the line increases clutter imo and reduces the risk that it will be accidentally restored. I suppose there might also be a negligible performance reason for removing the line too. It's one less thing to parse.

@@ -217,7 +217,7 @@

html_theme_options = {
'canonical_url': "https://docs.ansible.com/ansible/latest/",
'hubspot_id': '330046',
# 'hubspot_id': '330046',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# 'hubspot_id': '330046',

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

Hmm. Is it just me or is the left nav cut off at the bottom?

image

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

I've kicked off a run to deploy this branch to test: https://github.com/ansible/ansible-documentation/actions/runs/10827409830

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

Yeah it looks like the left nav is truncated on stage too: https://ansible-community.github.io/package-doc-builds/

@oraNod
Copy link
Contributor

oraNod commented Sep 12, 2024

Closed and re-opened to check the RTD preview build. It looks like there's still a reference to the stage-ansible-core project alongside the new ansible-core project.

@samccann
Copy link
Contributor Author

Closing this - the problem I think is in the sphinx ansible theme itself - https://github.com/ansible-community/sphinx_ansible_theme/blob/main/src/sphinx_ansible_theme/extranav.html

So will remove the ad from there.

@samccann samccann closed this Sep 16, 2024
@oraNod
Copy link
Contributor

oraNod commented Sep 16, 2024

@samccann It might still be worth removing that line from the conf file after you make the change to the sphinx theme.

@samccann
Copy link
Contributor Author

A good point.

@samccann samccann reopened this Sep 16, 2024
@samccann samccann marked this pull request as draft September 16, 2024 17:53
@oraNod oraNod added the backport-2.18 Automatically create a backport for the stable-2.18 branch label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants