-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: refresh docs build dependencies #1708
Conversation
@oraNod @gotmax23 - anyone know why rstcheck is dropped down multiple versions in this PR - https://github.com/ansible/ansible-documentation/pull/1708/files#diff-f3e33d99f9b9fef050ee5b226fa3aedb48919f53d607a445970e11ffb0bf66ffR108 |
nice catch @samccann I'm not sure why rstcheck was dropped down. initially I was thinking maybe it was related to one of the other dependencies, perhaps sphinx. but I don't think that's the case. I know rstcheck has an upper bound:
pip-compile --upgrade <requirements>
|
ed88174
to
aa8ee89
Compare
aa8ee89
to
c03cbae
Compare
c03cbae
to
bcd78fd
Compare
bcd78fd
to
97668e0
Compare
@samccann Hey, I guess this one slipped through the cracks a little. I took another look and it seems there is an incompatibility with a docutils for rstcheck 5.0.0 and sphinx 7.4.7. I set up a test venv:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The rstcheck version change is in requirements-relaxed.txt which is used for dev / experimental builds so shouldn't be a problem.
No description provided.