This repository has been archived by the owner on Mar 13, 2020. It is now read-only.
[DNM] Split long rewritten imports into sets of shorter ones #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
changed the title
|
This is currently blocked by a (red)baron bug that I discovered while testing: PyCQA/redbaron#193. |
webknjaz
force-pushed
the
features/41-split-long-import-lines
branch
from
62f332f to
3a5d5c9
Compare
webknjaz
force-pushed
the
features/41-split-long-import-lines
branch
3 times, most recently
from
ee43c14 to
37927af
Compare
Closes ansible-community#41 Also: * Warn about lines being after the split * Add warnings for rewrite skip corner cases * Use absolute line length in check
It's a workaround for PyCQA/redbaron#190 Also: * Ensure there's LF @ rewritten module EOL
webknjaz
force-pushed
the
features/41-split-long-import-lines
branch
from
37927af to
84383a9
Compare
This reverts commit 84383a9.
|
I don't think that redbaron bug gets fixed anytime soon. We could instead use isort on the post-processing step which would be way better and easier to implement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only handles
from ... import ...nodes.Ref #41.